Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR - Enable stereo in more games #16952

Merged
merged 2 commits into from
Feb 12, 2023
Merged

OpenXR - Enable stereo in more games #16952

merged 2 commits into from
Feb 12, 2023

Conversation

lvonasek
Copy link
Contributor

This PR removes limitation for stereo "only if UnitsPerMeter is specified".

Let me explain why I think this is a good decision. Getting assets/compatvr.ini as a statistical coverage, I figured out:

  • about 50% of games have the UnitsPerMeter = 1.0 - this is our default value
  • about 40% of games have the UnitsPerMeter > 1.0 - these games will have a low stereo effect (*)
  • about 10% of games have the UnitsPerMeter < 1.0 - these games will have a wrong stereo (*)

(*) when the UnitsPerMeter value isn't specified

To sum up:

  • before this PR we supported stereo on about 10% of all PSP games
  • after this PR we will support stereo on about 50% of all PSP games (meaing the correct stereo separation is in place)
  • after this PR the stereo will be too low on 40% of all PSP games (this is not worse than than without this PR)
  • after this PR the stereo will be broken on 10% of all PSP games (I will be fixing these when reported)

@hrydgard
Copy link
Owner

Yeah, this is probably a good plan. Bigger chance you'll get reports of failure cases too.

@hrydgard hrydgard merged commit 6007f54 into hrydgard:master Feb 12, 2023
@lvonasek lvonasek deleted the compat_openxr_stereo branch February 12, 2023 09:36
@unknownbrackets unknownbrackets added this to the v1.15.0 milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants