Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Fix disabling VSync on SDL platforms that support IMMEDIATE but not MAILBOX #18087

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Sep 6, 2023

This includes Mac M1.

Also allow IMMEDIATE and ignore FIFO_RELAXED on Android - the latter is simply not ever supported. Well, IMMEDIATE isn't supported much either on Android but its semantics are clearer than FIFO_RELAXED.

Fixes #18084

@hrydgard hrydgard added SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan labels Sep 6, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Sep 6, 2023
@hrydgard hrydgard merged commit 942a1c0 into master Sep 7, 2023
18 checks passed
@hrydgard hrydgard deleted the vsync-immediate-fix branch September 7, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Mac with Vulkan (MoltenVK), setting VSync to off still gets stuck in FIFO mode
1 participant