Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiger Woods PGA Tour 10 - strange striped backgrounds in UI windows (DXT5 issue?) #18108

Closed
hrydgard opened this issue Sep 8, 2023 · 4 comments · Fixed by #18554
Closed

Tiger Woods PGA Tour 10 - strange striped backgrounds in UI windows (DXT5 issue?) #18108

hrydgard opened this issue Sep 8, 2023 · 4 comments · Fixed by #18554
Labels
GE emulation Backend-independent GPU issues OpenGL Vulkan
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented Sep 8, 2023

Reported by djfil007 on Discord (reported on OpenGL, Android, but also reproduces on other platforms). Can be seen in the compat reports:

https://report.ppsspp.org/game/ULUS10420_1.00#report-compat-686272

GE frame dump: tiger ULUS10420.zip

image

With 2x texture scaling:

image

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Sep 8, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Sep 8, 2023
@hrydgard hrydgard added the OpenGL label Sep 8, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented Sep 8, 2023

The texture used when drawing the striped UI is a 2x32 DXT5 texture, at 0x08c65f50, draw 21979 and 21980, plus some more. Might be some odd behavior there - I think we try to decode 4x4 blocks into a stride of 2, and mayhem happens as the lines clash with each other.

It's not intended to be stripy, btw: https://www.youtube.com/watch?v=cszpSxjXEo8

@DjFIL007
Copy link

DjFIL007 commented Sep 8, 2023

Thanks again for creating this.

compat-285595

above screenshot was shared by another user on https://report.ppsspp.org/game/ULUS10420_1.00#report-compat-285595 (they were back on 2019-09-02 version v1.8.0... but on a windows device... however it shows the intended result)

@hrydgard hrydgard changed the title Tiger Woods - strange striped backgrounds in UI windows Tiger Woods - strange striped backgrounds in UI windows (DXT5 issue?) Sep 9, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented Sep 9, 2023

Yeah, indeed, hm, that's interesting.

Also, looking at the DXT5 code we do seem to handle small widths correctly - at least it looks like it.

@hrydgard hrydgard changed the title Tiger Woods - strange striped backgrounds in UI windows (DXT5 issue?) Tiger Woods PGA Tour 10 - strange striped backgrounds in UI windows (DXT5 issue?) Dec 15, 2023
@hrydgard
Copy link
Owner Author

It was a bug in the DXT5 decoder. fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues OpenGL Vulkan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants