Optimize DrawPixels for 16-bit RGB565 copies #18416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…propriate. Optimization for God of War on low-end platforms. Avoids calling a color conversion function that's currently only SIMD-optimized on x86, so will also benefit ARM a little bit.
hrydgard
force-pushed
the
drawpixels-16-bit-opt
branch
from
b23596c
to
7782548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are done repeatedly in God of War, and are slightly expensive on platforms like RISC-V due to unnecessary color conversion (we don't have optimized color conv functions for RISC-V yet).
So let's just use a 16-bit texture format directly if available instead of converting (and if the opposite RGB16 format is available, use that since conversion is cheap even without SIMD).