Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unpausing with keys bound to pause #18591

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Dec 20, 2023

Fixes #9592 .

Normally we don't process key bindings in the UI. This adds a special case for this on the pause screen only.

Doesn't work with axis events.

Also throws in a background color fix.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Dec 20, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Dec 20, 2023
@hrydgard hrydgard merged commit eff01d1 into master Dec 20, 2023
18 checks passed
@hrydgard hrydgard deleted the unpause-with-pause-binding branch December 20, 2023 18:02
Comment on lines 1582 to +1583
if (gpu && !gpu->PresentedThisFrame() && !skipBufferEffects) {
draw->BindFramebufferAsRenderTarget(nullptr, { RPAction::CLEAR, RPAction::CLEAR, RPAction::CLEAR }, "EmuScreen_NoFrame");
draw->BindFramebufferAsRenderTarget(nullptr, { RPAction::CLEAR, RPAction::CLEAR, RPAction::CLEAR, clearColor }, "EmuScreen_NoFrame");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this handle the stepping case above?

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause button not closing pause menu
2 participants