Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platypus: OpenGL rendering error #19235

Closed
hrydgard opened this issue Jun 2, 2024 · 1 comment · Fixed by #19364
Closed

Platypus: OpenGL rendering error #19235

hrydgard opened this issue Jun 2, 2024 · 1 comment · Fixed by #19364
Labels
GE emulation Backend-independent GPU issues OpenGL
Milestone
v1.18.0

Comments

@hrydgard
Copy link
Owner

hrydgard commented Jun 2, 2024

This seems to affect Android on some devices.

framedump:

ULUS10203.zip

bad:
image
good:
image
@hrydgard hrydgard added OpenGL GE emulation Backend-independent GPU issues labels Jun 2, 2024
@hrydgard hrydgard added this to the v1.18.0 milestone Jun 2, 2024
@hrydgard
Copy link
Owner Author

hrydgard commented Jul 22, 2024 •
edited
Loading

The game is using color test != 0xFFFFFF to mask the background of its sprites, which is very unusual!

No obvious reason it shouldn't work, likely a precision issue where it's just a little bit off in color somehow and doesn't exactly match for some reason.

Can't reproduce on PC, but can on Pocophone F1 (Adreno 630). On Vulkan it's fine though.

hrydgard added a commit that referenced this issue Jul 22, 2024
@hrydgard
Slightly nudge down the multiplier used for float->u8 conversion in f…
6e0ec4a 
…ragment shaders

Seems in lowp precision (as seen on some Android devices) this got
rounded up to 256 when multiplied by 1.0, causing the u8 to overflow, giving
us the wrong value instead of nicely rounding down to 255 with the floor
function.

Fixes #19235
@hrydgard hrydgard mentioned this issue Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GE emulation Backend-independent GPU issues OpenGL
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging a pull request may close this issue.

Slightly nudge down the multiplier used for float->u8 conversion in fragment shaders hrydgard/ppsspp
1 participant
@hrydgard