Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT/Dynarec crash upon load on RISC-V #19266

Closed
5 tasks done
archanox opened this issue Jun 10, 2024 · 8 comments · Fixed by #19268
Closed
5 tasks done

JIT/Dynarec crash upon load on RISC-V #19266

archanox opened this issue Jun 10, 2024 · 8 comments · Fixed by #19268
Labels
IRInterpreter Occurs with IR Interpreter but not with another CPU backend.
Milestone

Comments

@archanox
Copy link
Contributor

archanox commented Jun 10, 2024

Game or games this happens in

ULUS-10093 - WRC

What area of the game / PPSSPP

Upon loading the game.

What should happen

Dynarec/JIT should be functional when running on RISC-V

Logs

44:24:851 Core/System.cpp:428 N[BOOT]: PPSSPP v1.17-875-g5dec3ca2db
44:25:338 root         N[BOOT]: UI/EmuScreen.cpp:384 Booted /media/debian/Storage/Isos/World_Rally_Championship_USA_PSP-pSyPSP.iso...
44:25:339 root         E[SYSTEM]: Common/Log.cpp:73 (/media/debian/Storage/ppsspp/Core/MIPS/IR/IRNativeCommon.cpp:CompileIRInst:477): [false] (ULUS10093 WRC, 0.5s) Unexpected IR op 11
(/media/debian/Storage/ppsspp/Core/MIPS/IR/IRNativeCommon.cpp:CompileIRInst:477): [false] (ULUS10093 WRC, 0.5s) Unexpected IR op 11
Trace/breakpoint trap

Platform

Linux / BSD

Mobile device model or graphics card (GPU)

Radeon HD 7850

PPSSPP version affected

v1.17-875-g5dec3ca2db

Last working version

No response

Graphics backend (3D API)

Vulkan

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@anr2me
Copy link
Collaborator

anr2me commented Jun 10, 2024

(Assuming your ISO's CRC is good, and other CPU Cores are working fine)
Try disabling some of JIT functionality to find out which one causing the crash.

@hrydgard
Copy link
Owner

This seems related to my recent ir interpreter optimizations. Will look into it.

@archanox
Copy link
Contributor Author

(Assuming your ISO's CRC is good, and other CPU Cores are working fine)

Yeah it's the same CRC as my physical copy. It works fine on other platforms, and the it interpreter on RISC-V.

Try disabling some of JIT functionality to find out which one causing the crash.

Can do if it helps narrow down the issue.

@archanox
Copy link
Contributor Author

archanox commented Jun 11, 2024

I just tested the JIT with everything disabled, and it errors mostly the same.

Now it says

59:19:621 user_main    E[SYSTEM]: Common/Log.cpp:73 (/media/debian/Storage/ppsspp/Core/MIPS/IR/IRRegCache.cpp:operator():806): [false] (ULUS10093 WRC, 0.4s) Unexpected type: ?
(/media/debian/Storage/ppsspp/Core/MIPS/IR/IRRegCache.cpp:operator():806): [false] (ULUS10093 WRC, 0.4s) Unexpected type: ?
Trace/breakpoint trap

@hrydgard
Copy link
Owner

Thanks, I'll get this fixed soon.

@archanox
Copy link
Contributor Author

Thanks, this is now resolved in the IR Interpreter.

@hrydgard hrydgard added the IRInterpreter Occurs with IR Interpreter but not with another CPU backend. label Jun 19, 2024
@hrydgard hrydgard added this to the v1.18.0 milestone Jun 19, 2024
@hrydgard
Copy link
Owner

Hm? I thought it was only the actual IR JIT that was broken, did it also not run using the IR Interpreter previously? It should have.

@archanox
Copy link
Contributor Author

Sorry @hrydgard, right you are.
Have opened the new linked issue anyway as the problem in the title still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRInterpreter Occurs with IR Interpreter but not with another CPU backend.
Projects
None yet
3 participants