Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR - Hotfix for v69 #19416

Merged
merged 4 commits into from
Aug 27, 2024
Merged

OpenXR - Hotfix for v69 #19416

merged 4 commits into from
Aug 27, 2024

Conversation

lvonasek
Copy link
Contributor

@lvonasek lvonasek commented Aug 26, 2024

This is a fix for #19399.

There are two things what changed:

  1. The system started complaining about the reference pose when I create new XrSpace (coordinate system). It had definetely right to do that as the numbers where unlogical.
  2. Something changed with the depth buffer. I tried several things but only one thing which worked is to remove depth buffer from XR FBO (which shouldn't be a problem as the emulator uses own FBOs and copy into the XR FBO in the end, right?)

@hrydgard hrydgard added this to the v1.18.0 milestone Aug 27, 2024
@lvonasek
Copy link
Contributor Author

lvonasek commented Aug 27, 2024

DUring testing I figured out that Sonic Rivals is broken in immersive mode. I addresed that issue. The PR is ready to go.

@lvonasek lvonasek marked this pull request as ready for review August 27, 2024 07:35
@hrydgard
Copy link
Owner

OK, let't get it in.

@hrydgard hrydgard merged commit e416ccf into hrydgard:master Aug 27, 2024
19 checks passed
@lvonasek lvonasek deleted the hotfix-openxr-v69 branch August 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants