Simplify reporting code (removing two threads), other minor fixes #19561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the IsFull check.
hrydgard
added
the
Code Cleanup
hrydgard
force-pushed
the
more-misc-fixes
branch
from
81f52d3
to
6a74353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, even more fixes. Trying to apply an extra layer of polish this time.
This fixes and simplifies some code pointed to by hang and crash reports from the Play Console. The extra reporting threads cause a lot of ANR (application not responding) during game exit, for example - with this, they're gone.
Additionally, fixes a possible crash in the JIT after playing for a long time in certain games.