Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Fantasy III (NPUH10125): Minor regression in text/font alignment in all PPSSPP revisions since v0.9.1-2199-gea05c93 #4404

Closed
solarmystic opened this issue Nov 2, 2013 · 9 comments · Fixed by #4789

Comments

@solarmystic
Copy link
Contributor

Issue is as stated in the title. Responsible commit found via bisecting is v0.9.1-2166-g92042e6 92042e6 by @raven02 merged into master with v0.9.1-2199-gea05c93 ea05c93

capture

Contrary to what the commit says (i.e. it should only affect the game when using the provided PSP fonts), this issue happens when using either the ripped original PSP fonts or when using the provided packaged fonts in this game.

Screenshots showing the issue (observe the letters "u" and "g" in the dialogue boxes) when using:

Provided packaged fonts
2166raven02responsibleppssppfonts

Ripped original fonts
2166raven02responsiblepsporiginal

Last unaffected revision in chronological order is v0.9.1-2197-g7b982c0 7b982c0 when using either the provided PSP fonts or the original PSP fonts ripped from the hardware

Provided packaged fonts:
2197ppsspp

Ripped original fonts:
2197oripsp

Tested on the following machine:

sysspec

@solarmystic
Copy link
Contributor Author

The issue is still present in the latest master at the moment (v0.9.5-31-g72950d8 72950d8)

31

@dbz400
Copy link
Contributor

dbz400 commented Nov 2, 2013

Thanks @solarmystic .I will check this out.

@dbz400
Copy link
Contributor

dbz400 commented Nov 2, 2013

@solarmystic , jsut wonder what is the size of your ripped original PSP font jpn0.pgf ? (My one is 1587100 bytes)

@solarmystic
Copy link
Contributor Author

@raven02 mine is 1581700 bytes

capture

@dbz400
Copy link
Contributor

dbz400 commented Nov 2, 2013

Thanks @solarmystic .Will pull the fix shortly.

@solarmystic
Copy link
Contributor Author

Issue fixed with #4410, at least for original ripped PSP fonts.Thanks @raven02

Should I close this?

@unknownbrackets
Copy link
Collaborator

Does it still happen out-of-the-box with the fonts PPSSPP comes with?

-[Unknown]

@solarmystic
Copy link
Contributor Author

@unknownbrackets

It still happens for the out-of-the-box provided fonts. @raven02 did mention in his pull request #4410 that the fix was meant for the original ripped PSP fonts.

Screenshot using provided fonts:

capture

@unknownbrackets
Copy link
Collaborator

Right, so this is still an issue. I mean, it's clearly a hack, this result seemed expected to me.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants