Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression:Bakemonogatari corrupted frames in video. #5266

Closed
daniel229 opened this issue Jan 29, 2014 · 8 comments · Fixed by #8867
Closed

Regression:Bakemonogatari corrupted frames in video. #5266

daniel229 opened this issue Jan 29, 2014 · 8 comments · Fixed by #8867

Comments

@daniel229
Copy link
Collaborator

Since #5212
01

Reverted that change
02

@sum2012
Copy link
Collaborator

sum2012 commented Jan 29, 2014

Do #5245 fix it ?

@unknownbrackets
Copy link
Collaborator

I guess this is somehow affecting the speed of decoding or whether it waits or something. Is this near the front of the video or in the middle?

It may be that these values need to come from feedback from the decoder.

-[Unknown]

@daniel229
Copy link
Collaborator Author

@sum2012 that does not help.
@unknownbrackets It is the biginning of video,the first frame is correct,then it is being corrupted for a second.
here is a video
http://www.youtube.com/watch?v=Vr1zDG0IE54

@dbz400
Copy link
Contributor

dbz400 commented Jan 29, 2014

@daniel229 , if just simply set the following , it did help , right ?

ctx->avc.avcDecodeResult = 0;

@daniel229
Copy link
Collaborator Author

That does not help,and the first frame start to be corrupted,the master build the first frame is fine.Revert either one would not help,should revert both.

@dbz400
Copy link
Contributor

dbz400 commented Jan 29, 2014

I see.

@unknownbrackets
Copy link
Collaborator

My theory at least in the past was that initAddr should contain a "1" when a frame was fully decoded, and "0" otherwise, or something.

So possibly, for the first few calls this game expects a 0, but another game might expect a 1.

Best thing would be to look at the code around this call in one of the affected games and see what logic it uses based on the resulting value. Clearly if this value changes whether there are corrupted frames or not, it must affect the game's behavior in some way.

-[Unknown]

@dbz400
Copy link
Contributor

dbz400 commented Jan 29, 2014

Yep, Project Diva 2 same as well .It start at 1st frame
screen00410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants