-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression:Bakemonogatari corrupted frames in video. #5266
Comments
Do #5245 fix it ? |
I guess this is somehow affecting the speed of decoding or whether it waits or something. Is this near the front of the video or in the middle? It may be that these values need to come from feedback from the decoder. -[Unknown] |
@sum2012 that does not help. |
@daniel229 , if just simply set the following , it did help , right ? ctx->avc.avcDecodeResult = 0; |
That does not help,and the first frame start to be corrupted,the master build the first frame is fine.Revert either one would not help,should revert both. |
I see. |
My theory at least in the past was that initAddr should contain a "1" when a frame was fully decoded, and "0" otherwise, or something. So possibly, for the first few calls this game expects a 0, but another game might expect a 1. Best thing would be to look at the code around this call in one of the affected games and see what logic it uses based on the resulting value. Clearly if this value changes whether there are corrupted frames or not, it must affect the game's behavior in some way. -[Unknown] |
Since #5212
Reverted that change
The text was updated successfully, but these errors were encountered: