Save FBOs on decimate when a safe size is known #8757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified that scissor affects clears as well. This allows a clear to be detected in Katamari Damacy.
| return false; | ||
| if (i > 0 && transformed[i].x != transformed[i - 1].x) | ||
| return false; | ||
| } else { | ||
| if ((i & 1) && (transformed[i].color0_32 != matchcolor || transformed[i].z != matchz)) | ||
| if (transformed[i].color0_32 != matchcolor || transformed[i].z != matchz) |
There was a problem hiding this comment.
Why remove "i & 1"? It's there because only the color of the 2nd of every pair of vertices used to draw rectangles matter in clear-mode.
There was a problem hiding this comment.
if ((i & 1) == 0) {
/// stuff
} else {
if ((i & 1) != 0) {
// other stuff
}
}It's not needed, we're already in the else condition for that check. To me it just makes the code more confusing because it's in the else and makes me have to do a double-take on the code to make sure it's an always-true condition.
-[Unknown]
There was a problem hiding this comment.
FWIW i > 0 is also always true since the loop starts at 1, but that one isn't confusing.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can know that if an FBO is cleared up to scissor, the size of the clear is definitely <= the size of the FBO. That means we can safely write out the bytes of the clear.
This may help games in #8359 and #6261 as well. I've classified it under a "slow effect", but it mainly makes FBO decimation slower which ought not be common.
-[Unknown]