-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLB Games 06-11 Pitching Meter Freezes #9308
Comments
No screenshot? Android or Windows or what platform? This is not a useful bug report. |
Does this still happen? Could you try exporting a GE frame dump? These help a lot. See here for instructions - it's not hard and works on Android too: You can zip that and then drag and drop it into a reply here. -[Unknown] |
since the OP dint reply, i am chiming in....here is the dump file zipped....i took the recording from android phone, so i dont know if it came out okay or not.... |
I looked through the dump, but unfortunately it doesn't seem like the game drew the pitching meter on that frame at all. You can open the generated file in PPSSPP, and it'll show what was captured. In this case, we need one that shows the pitching meter itself so we can tell how the game is drawing it. -[Unknown] |
I tried making a dump from my PC, but all I could get was a screenshot type
image....is there any way to make a video snippet?
…On Sun, Jan 3, 2021 at 9:36 PM Unknown W. Brackets ***@***.***> wrote:
I looked through the dump, but unfortunately it doesn't seem like the game
drew the pitching meter on that frame at all.
You can open the generated file in PPSSPP, and it'll show what was
captured. In this case, we need one that shows the pitching meter itself so
we can tell how the game is drawing it.
-[Unknown]
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9308 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASJZR4XBYDIM463XL5Z54WLSYCFJFANCNFSM4DAEQUVQ>
.
|
UCUS98758.zip |
It takes until 11811/13482 to get the background drawn, which ends up with mostly clear stencil (except shadows) and filled depth (but some depth values on the field.) The players and the mound use depth. At 13240/13482, we're finally to the pitching meter itself. It uses the same texture for a bunch of draws, and finally draws the actual meter at 13362/13482. This is just a triangle strip (146 verts), not a patch or anything. The texture is pretty small, I wonder if this is a texture hashing issue like the Z.H.P. issue somehow? It doesn't look like it, though. If you create a texture ini for this game (like you were creating texture replacements), and then change the hash to xxh64, does it work? If yes, this is likely a texture hash issue... -[Unknown] |
It'd also help to confirm whether this works fine under the software renderer (it probably does, but it may be slow.) -[Unknown] |
Just here to confirm the pitching meter works with software renderer but it runs at around 20 FPS for me. Playing MLB 08 The Show specifically. And changing the hash to xxh64 did not seem to work, unless I missed a step. Version 1.12.3-922-g1f71a69be |
Okay, then it does seem likely it might be a small texture issue or some framebuffer write being missed. FWIW, the latest git build may improve performance of the software render by a chunk compared to that version, although it probably still won't be full speed I suppose. Interesting if XXH64 doesn't help. That makes it seem like it's a framebuffer write. -[Unknown] |
There's a video of the problem here: #11596 (comment) It does seem like some of it shows, and then it hits collisions or something. -[Unknown] |
Tested in latest build under Vulkan backend. Pitcher bar HUD is not showing charge position correctly. In software render you can see power line bar in the whole bar perfectly: But in any other render (well at least Vulkan an Direct3D 11) power line bar dissapear up to the mid of the power bar and then comes back: Here is a video to explain the issue better: Ucus98696.2022-12-16.23-53-11.mp4 |
The problem has repro'd consistently for last years. Could you bump up the priority? |
OK, finally looking into this a little bit. The marker is drawn using the same arc-shaped mesh every frame, the only thing that changes it seems is the position of the white dot in the top line of the bound 64x4 texture: Still unclear why we are not updating this texture properly. It looks like it's a regular texture and not rendered or copied to (though not sure about the latter yet). But, forcing the texture fullhash to fail every frame makes it work, so there's something going wrong in the texture cache, like the fullhash not picking these small changes up, which seems weird... |
Aha! The texture is swizzled, which means it's stored in memory in Nx8 blocks. But the texture is only 4 pixels high, so the texture wastes 4 vertical pixels of space of each block, doubling the space requirements. We calculated the range of memory to hash as if it was linear, so effectively we only hashed the left half of the texture, leading to the freeze! Fixing. |
@hrydgard Thanks for your time and expertise. It's been a problem nagging for half a decade. :) |
MLB Games 06-11 Pitching Meter Freezes
The text was updated successfully, but these errors were encountered: