Improve support for mipmaps and related headless fixes #9633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other clause was mip 1.
These generally work, as long as the mip levels are halving.
Only GE_{LINEAR,NEAREST}_MIPMAP_* enable mipmaps.
Was getting crashes until I realized buffered rendering was on.
|
Nice. Only issue I see is that GL_TEXTURE_MAX_LOD/MIN_LOD are applied even where not supported (ES2), and given what we know about the state of GLES2 drivers, that might not be a good thing, even if they should technically ignore these... |
|
Ah right, yes. Updated. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves mipmap handling in the typical halving levels case:
CONST: Works in GLES3/desktop GL and D3D11. Approximated in D3D9.
AUTO: Works in desktop GL, D3D11, and D3D9. Could maybe be supported in GLES3 via shader.
SLOPE: Added reporting, but doesn't work properly anywhere.
Vulkan is untouched because it can't be tested in headless (no readback yet.)
Note that D3D9 calls the base mip level "max" because it's the "largest" level. It's an integer, so CONST doesn't even support blending properly.
Of course, CONST is probably most often used when mipmaps do NOT halve in size, but might as well support it for the easier cases.
-[Unknown]