Pipeline/shader race-condition-during-shutdown crash fix #18183
Merged
+40
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you exit the game while shaders are still compiling, we could end up in a situation where we cleared the shader cache while pipeline creation (using said shaders) was still going on on the worker pool, especially on Android where pipeline creation can be notoriously slow.
Now, kill the pipeline cache first, and while doing so, block the shutdown process until all pending shaders are finished compiling.
Potentially if many are queued we could add a cancelling facility, but likely not worth the trouble.
These crashes weren't too damaging to the play experience since they don't happen while you're actually playing, only when leaving the game, but this pollutes the Google Play crash logs, and the app exiting when you exit a game is a bit unexpected.
Also, sneak in a leak fix on image view creation failure, although very likely very obscure. I have seen a crash that seems connected though.