Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies read from storage every request #8

Open
sean3z opened this issue Jan 4, 2016 · 1 comment
Open

Cookies read from storage every request #8

sean3z opened this issue Jan 4, 2016 · 1 comment

Comments

@sean3z
Copy link

sean3z commented Jan 4, 2016

Have you given any thought to optimizing this a bit by ensuring the entire cookie storage (locaStorage.cookies) isn't read and parsed on every cookie request?

While the current implementation works fine for small-medium storages, it can get costly when working with larger sets. I thought about having a crack at a PR but wasn't sure if it was on your radar or what your thoughts were.

Thanks!

@hstove
Copy link
Owner

hstove commented Jan 8, 2016

I'd be happy to consider any PR submissions to this project. I am not working on it actively at this moment.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants