Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

ci - cargo clippy should be run with --tests #105

Closed
PsiACE opened this issue Nov 13, 2021 · 5 comments · Fixed by #106
Closed

ci - cargo clippy should be run with --tests #105

PsiACE opened this issue Nov 13, 2021 · 5 comments · Fixed by #106

Comments

@PsiACE
Copy link

PsiACE commented Nov 13, 2021

Otherwise tests aren't covered.

@tisonkun
Copy link
Contributor

@PsiACE I notice that maybe we should keep CONTRIBUTING.md up-to-date also. Would you like to take a look or create an issue first?

@tisonkun
Copy link
Contributor

We take about how to run tests and linters in CONTRIBUTING.md but out-of-sync in this issue and #101 :P

@PsiACE
Copy link
Author

PsiACE commented Nov 13, 2021

@PsiACE I notice that maybe we should keep CONTRIBUTING.md up-to-date also. Would you like to take a look or create an issue first?

I will update it. Shall we consider adding a makefile to simplify the commands?

@tisonkun
Copy link
Contributor

@PsiACE I tend not to do so - it's a bit over-engineering. Cargo is designed to be self-service, and even projects like tokio don't require a Makefile. I prefer to collaborate with the Rust community than maintain two build tools.

@PsiACE
Copy link
Author

PsiACE commented Nov 13, 2021

@PsiACE I tend not to do so - it's a bit over-engineering. Cargo is designed to be self-service, and even projects like tokio don't require a Makefile. I prefer to collaborate with the Rust community than maintain two build tools.

Well, if it is necessary, we can add some custom cmd to .cargo/config.toml. Of course, it's too early.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants