-
Notifications
You must be signed in to change notification settings - Fork 65
Bring back hash-engine #272
Comments
hash-engine is mainly for demonstration when it is built. There is no long-term plan to maintain it so far. So I don't suggest bringing it back simply to make something work. However, if someone has a plan to turn hash-engine into something more valuable, I am happy to know. |
@huachaohuang a demonstration is enough for contributors understanding how to build an engine. Currently, there's no workable engine which is a user directly talk to. If you don't think hash-engine valuable and work for connect luna-engine to the kernel, you can remove hash-engine code to reduce confusion. For me, it's a cutting point for getting used to Engula's architecture. |
I don't see the necessity to remove the hash-engine either. Just leave it alone until we really decide to drop it.
If this is the purpose, I suggest that you build an engine outside of the project using the low-level modules. It helps us understand how it is like to build a third-party engine in the current stage :) |
Closed as invalid. |
Inspired by #221 (comment) and as #269 merged, I'm going to bring back hash-engine.
It's also a blocker for #226.
However, I don't want to act as an assignee, which means you can take it over if it blocks you also. And I think this is a valuable task for anyone who wants to implement their own engine.
The text was updated successfully, but these errors were encountered: