Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Bring back hash-engine #272

Closed
tisonkun opened this issue Jan 8, 2022 · 4 comments
Closed

Bring back hash-engine #272

tisonkun opened this issue Jan 8, 2022 · 4 comments

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Jan 8, 2022

Inspired by #221 (comment) and as #269 merged, I'm going to bring back hash-engine.

It's also a blocker for #226.

However, I don't want to act as an assignee, which means you can take it over if it blocks you also. And I think this is a valuable task for anyone who wants to implement their own engine.

@huachaohuang
Copy link
Owner

hash-engine is mainly for demonstration when it is built. There is no long-term plan to maintain it so far. So I don't suggest bringing it back simply to make something work. However, if someone has a plan to turn hash-engine into something more valuable, I am happy to know.

@tisonkun
Copy link
Contributor Author

tisonkun commented Jan 9, 2022

@huachaohuang a demonstration is enough for contributors understanding how to build an engine. Currently, there's no workable engine which is a user directly talk to.

If you don't think hash-engine valuable and work for connect luna-engine to the kernel, you can remove hash-engine code to reduce confusion.

For me, it's a cutting point for getting used to Engula's architecture.

@huachaohuang
Copy link
Owner

I don't see the necessity to remove the hash-engine either. Just leave it alone until we really decide to drop it.

For me, it's a cutting point for getting used to Engula's architecture.

If this is the purpose, I suggest that you build an engine outside of the project using the low-level modules. It helps us understand how it is like to build a third-party engine in the current stage :)

@tisonkun
Copy link
Contributor Author

tisonkun commented Jan 9, 2022

Closed as invalid.

@tisonkun tisonkun closed this as completed Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants