Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for webpacker #191

Open
do-you-dare opened this issue May 27, 2020 · 2 comments
Open

Add support for webpacker #191

do-you-dare opened this issue May 27, 2020 · 2 comments

Comments

@do-you-dare
Copy link

Rails 6 uses webpack by default, and it seems that social-share-button doesn't support it yet. I seems to involve adding a package.json and publishing the project on npm. An example can be found here: ifad/data-confirm-modal#53, found on this webpacker issue: rails/webpacker#57.

Do you plan to support installing with webpacker?

@martintsan
Copy link

#189 #189 (comment)

@kwent
Copy link

kwent commented Apr 9, 2021

Way too hacky. Should not require coffee-loader, should not require('some_erb_file.erb') and so on.

Js should be compiled and ready to be imported as require("social-share-button") directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants