-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade httpx #1935
Upgrade httpx #1935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
9fba08d
to
eb8df1f
Compare
ReuseableSanicTestClient and DelayableHTTPConnection are some pretty hairy hacks I put together a couple of years ago in order to test the HTTP Keep-Alive mechanism, and Request Timeouts respectively. |
Black test failing:
|
I agree. I have written and rewritten those several times because of the fast pace at which underlying libraries reorganize themselves. I do have a thought on how to handle, and this is actually THE reason I think we need to hold off on sanic-testing for now. While I understand the desire to move them out to keep them closer, I think the test themselves need to stay here because it is Sanic functionality we need to worry about. Therefore, I want to add the functionality into the core of sanic-testing so the tests can stay, but the hack clients can go. |
Had to upgrade |
I had thought pretty long about whether to get the PR for removing
httpx
requirement (#1850), but that didn't seem quite appropriate just yet.Because
httpx
is a fairly fast moving project, there were a number of changes needed to be made to some tests as well as the test client. Hopefully, we will getsanic-testing
completed and then we will not need to deal with these changes here.