Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport stream header fix #1959

Merged
merged 7 commits into from
Oct 25, 2020
Merged

Backport stream header fix #1959

merged 7 commits into from
Oct 25, 2020

Conversation

ahopkins
Copy link
Member

This is a backport of #1957 to the last LTS.

See also #1730 and #1653.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #1959 into 19.12LTS will increase coverage by 0.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           19.12LTS    #1959      +/-   ##
============================================
+ Coverage     89.38%   89.95%   +0.56%     
============================================
  Files            25       25              
  Lines          2930     2936       +6     
  Branches        543      544       +1     
============================================
+ Hits           2619     2641      +22     
+ Misses          237      222      -15     
+ Partials         74       73       -1     
Impacted Files Coverage Δ
sanic/request.py 99.60% <ø> (ø)
sanic/router.py 95.49% <ø> (ø)
sanic/worker.py 84.29% <ø> (+1.65%) ⬆️
sanic/__version__.py 100.00% <100.00%> (ø)
sanic/asgi.py 94.08% <100.00%> (+3.27%) ⬆️
sanic/response.py 100.00% <100.00%> (ø)
sanic/server.py 75.28% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a44a27...3b31cc6. Read the comment docs.

@ashleysommer
Copy link
Member

Go ahead and merge and release 19.12.3

@ahopkins ahopkins merged commit c5070bd into 19.12LTS Oct 25, 2020
@ahopkins ahopkins deleted the backport-stream-header-fix branch October 25, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants