Merge pull request #234 from humhub/internal-f-53-external-links-issu…

…e-ios

Redirect to external screen for links in ios

lib/pages/web_view.dart

@@ -11,6 +11,7 @@ import 'package:humhub/models/channel_message.dart';
 import 'package:humhub/models/hum_hub.dart';
 import 'package:humhub/models/manifest.dart';
 import 'package:humhub/pages/opener.dart';
+import 'package:humhub/util/black_list_rules.dart';
 import 'package:humhub/util/connectivity_plugin.dart';
 import 'package:humhub/util/const.dart';
 import 'package:humhub/util/extensions.dart';
@@ -144,11 +145,19 @@ class WebViewAppState extends ConsumerState<WebView> {
     WebViewGlobalController.ajaxSetHeaders(headers: ref.read(humHubProvider).customHeaders);
 
     //Open in external browser
-    final url = action.request.url!.origin;
+    final url = action.request.url!.rawValue;
+    /// First BLOCK everything that rules out as blocked.
+    if (BlackListRules.check(url)) {
+      return NavigationActionPolicy.CANCEL;
+    }
     if (!url.startsWith(_manifest.baseUrl) && action.isForMainFrame) {
       _authBrowser.launchUrl(action.request);
       return NavigationActionPolicy.CANCEL;
     }
+    if (!action.isForMainFrame) {
+      await launchUrl(action.request.url!.uriValue, mode: LaunchMode.externalApplication);
+      return NavigationActionPolicy.CANCEL;
+    }
     // 2nd Append customHeader if url is in app redirect and CANCEL the requests without custom headers
     if (Platform.isAndroid ||
         action.navigationType == NavigationType.LINK_ACTIVATED ||

lib/util/auth_in_app_browser.dart

@@ -14,10 +14,11 @@ class AuthInAppBrowser extends InAppBrowser {
   AuthInAppBrowser({required this.manifest, required this.concludeAuth}) {
     settings = InAppBrowserClassSettings(
       browserSettings: InAppBrowserSettings(
-        hideUrlBar: true,
-        hideToolbarTop: true,
-        toolbarTopBackgroundColor: HexColor(manifest.themeColor),
-      ),
+          hideUrlBar: true,
+          shouldCloseOnBackButtonPressed: true,
+          toolbarTopBackgroundColor: HexColor(manifest.themeColor),
+          toolbarTopTintColor: HexColor(manifest.themeColor),
+          presentationStyle: ModalPresentationStyle.OVER_FULL_SCREEN),
       webViewSettings: InAppWebViewSettings(
           javaScriptEnabled: true,
           useShouldOverrideUrlLoading: true,

lib/util/black_list_rules.dart

@@ -0,0 +1,16 @@
+class BlackListRules {
+  // Define the blacklist of URLs
+  static const List<String> _blacklist = [
+    'https://discord.com/',
+  ];
+
+  /// Checks if the provided [url] is on the blacklist.
+  /// Returns true if the URL is blacklisted, false otherwise.
+  static bool check(String url) {
+    // Normalize the URL by trimming whitespace and converting to lowercase
+    final normalizedUrl = url.trim().toLowerCase();
+
+    // Check if the normalized URL is in the blacklist
+    return _blacklist.contains(normalizedUrl);
+  }
+}