Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test & Release #1

Closed
luke- opened this issue Nov 16, 2021 · 6 comments · Fixed by #2
Closed

Test & Release #1

luke- opened this issue Nov 16, 2021 · 6 comments · Fixed by #2
Assignees

Comments

@luke-
Copy link
Contributor

luke- commented Nov 16, 2021

No description provided.

@serh-mosk
Copy link
Contributor

To check the operation of this module, I need Client ID and Client secret, which can be obtained only by creating an application in the https://developer.linkedin.com/ cabinet. Can you provide them to me or do I need to create a test LinkedIn account?

@luke-
Copy link
Contributor Author

luke- commented Apr 17, 2023

@yuriimaz Would be great if you can create a test linked in account

@serh-mosk
Copy link
Contributor

I created a test configuration for the project on LinkedIn and checked the operation of the authorization module.
Since a problem was detected with the registration of a new user in the event of an attempt to authorize using LinkedIn Auth, I made the appropriate changes in the registration class of the main project and created a pull-request with these changes humhub/humhub#6244. Please check that everything is correct and let me know if anything needs to be corrected.

@luke-
Copy link
Contributor Author

luke- commented Apr 19, 2023

@yuriimaz Thanks, I have already replied to the PR in the main project. Please try to make the changes only in the AuthClient of the LinkedIn project.

@serh-mosk
Copy link
Contributor

I've made changes to the module, but I can't create a branch and commit to it to prepare a pull request, because I don't have permission to do so. @luke- Can you check if editing rights are enabled for my account?

@luke-
Copy link
Contributor Author

luke- commented Apr 19, 2023

@yuriimaz Please try it again

@luke- luke- closed this as completed in #2 Apr 20, 2023
luke- added a commit that referenced this issue Apr 20, 2023
Fix #1: Normalized user attributes for registration capability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants