Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 5 migration #153

Open
marc-farre opened this issue Oct 2, 2024 · 3 comments
Open

Bootstrap 5 migration #153

marc-farre opened this issue Oct 2, 2024 · 3 comments

Comments

@marc-farre
Copy link
Contributor

marc-farre commented Oct 2, 2024 •
edited
Loading

@luke- I need to migrate this library.

Do you agree if I create a bs5 branch from master (develop seems to be outdated), and then you make it available in Packagist, so I can use it in HH bs5 branch via composer for testing?
@luke-
Copy link
Contributor

luke- commented Oct 3, 2024

@marc-farre Yes, please create a bs5 branch.

Did you saw the tipp here, to test the editor without a npm packagist release?
https://github.com/humhub/humhub-prosemirror?tab=readme-ov-file#test-editor-build-in-humhub

@marc-farre
Copy link
Contributor Author

marc-farre commented Oct 3, 2024 •
edited
Loading

@luke- No, I hadn't read the README to the end...🫣 Thanks!

@marc-farre
Copy link
Contributor Author

marc-farre commented Oct 6, 2024 •
edited
Loading

bs5 branch created and code updated for Bootstrap 5: https://github.com/humhub/humhub-prosemirror/tree/bs5

I also added Phase 3 - Merge the work to the RoadMap Wiki not to forget this ProseMirror update to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luke- @marc-farre