Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero "Max number of new conversations allowed" #395

Open
marc-farre opened this issue Jun 19, 2024 · 0 comments
Open

Allow zero "Max number of new conversations allowed" #395

marc-farre opened this issue Jun 19, 2024 · 0 comments

Comments

@marc-farre
Copy link
Contributor

What steps will reproduce the problem?

image

Create a new account and try sending a new message.

What is the expected result?

You are not allowed to send a message.

What do you get instead?

You can send a message.

Additional info

This is because of Config::canCreateConversation() which test if $maxConversations is empty:
https://github.com/humhub/mail/blob/master/models/Config.php#L115

We should distinguish 0 from ''.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants