-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v.17] Fix missing not saved
warning
#400
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gevorgmansuryan Do we really need to implement a separate confirm message here?
Can't we trigger the existing Core Confirm dialogue somehow?
If the core dialogue does not allow this atm, a core update might also be useful here. This could potentially also occur in other modules.
@luke- Core Confirm dialogue is browser thing, we do not control text. Current text is from core module, and used in many places. |
@gevorgmansuryan My point is that I would like to use the existing code here: It currently looks to me as if the mail module is implementing its own unload check. Can't we find a common reusable solution here? |
@luke- i can change it to use |
@gevorgmansuryan Yes please. It is not urgent and therefore a core solution would be preferable. |
…ing-not-saved-warning # Conflicts: # docs/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gevorgmansuryan Thanks ,please see my remarks below.
not saved
warningnot saved
warning
#399