-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiki page content title and overview numbering #357
base: master
Are you sure you want to change the base?
Wiki page content title and overview numbering #357
Conversation
Co-authored-by: Marius Meißner <[email protected]>
…om/Neo-Atlas/humhub_wiki into 1-content-overview-title-numbering
…github.com/Neo-Atlas/humhub_wiki into 1-content-overview-title-numbering" This reverts commit b1e21c5, reversing changes made to 59ee21d.
removed addditional empty spaces
removed additional space and tabspace
Co-authored-by: Marius Meißner <[email protected]>
Co-authored-by: Marius Meißner <[email protected]>
Co-authored-by: Marius Meißner <[email protected]>
Co-authored-by: Marius Meißner <[email protected]>
Co-authored-by: Marius Meißner <[email protected]>
Co-authored-by: Marius Meißner <[email protected]>
Co-authored-by: Marius Meißner <[email protected]>
Co-authored-by: Marius Meißner <[email protected]>
@vidhyasagargm, thank you for your PR. We’ve reviewed it, and it’s a great starting point. However, we would like you, if possible, to implement some changes/fixes. 1. Removing ON/OFF Button (Enh) 2. Space Module Config (Fix) Usually, global settings (Admin > Modules > Module Name), when set, are inherited by space-level module settings, allowing each space to customize the default setting to their needs. 3. Drag-and-Drop Feature Request Refresh (Fix) drag-and-drop.mov4. Headings Numeration (Fix) 5. Suffix Numbers with Brackets (Enh) 6. Page Title Numeration We appreciate your effort and look forward to seeing the updated version. Let us know if you have any questions or need clarification. Thanks again for your contribution! |
Greetings @mbumpalumpa,
|
@vidhyasagargm Okay, great, thanks! Also, we reviewed the mockups of point 5: "5. Suffix Numbers with Brackets (Enh) Numeration should be suffixed with ')' (e.g., 1.), 1.1.), etc.)," and we decided that it doesn’t look very good, so please ignore it, thanks! |
Hello @mbumpalumpa, |
Hello @mbumpalumpa, |
Hi @vidhyasagargm thanks! I will let you know when I'm done testing it. |
Hi @vidhyasagargm I have checked everything, and it seems to work fine. However, there is one small issue. You can see in the screenshot below that numeration is turned off for this particular Space. Despite this, the title within the page is still prefixed with "1". So in cases where Numeration is disabled; titles shouldn't be auto-prefixed. Numeration OffEditViewNumeration On |
Hello @mbumpalumpa, |
Hi @vidhyasagargm, thanks for the update! Everything is working fine now. One of our developers will be assigned to conduct a code review, after which we’ll inform you of the next steps. Thanks again! |
Currently the wiki page doesnt have numbering for the content of the page or even at the overview. It makes it difficult to read the list of pages and also the content of the page. For better visibility and structure numbering for the overview of wiki pages and also the content of wiki page has been created. There is also a toggle button to enable and disable the numbering and a configuration at the config page of the module to set default settings of the numbering. An internal code review process has already been done upfornt for all the changes in this PR.
Here is some of the screenshots of showing numbering enabled and disabled:
Wiki content numbering enabled:
Wiki content numbering disabled:
Overview numbering enabled:
Overview numbering disabled: