Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) change how PancakeSwap fetches V2 pools #371

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

  • Tested with CAKE-USDT and verified that /amm/price returned same buy and sell prices as PancakeSwap UI
{
    "chain": "{{chain}}",
    "network": "{{network}}",
    "connector": "pancakeswap",
    "base": "CAKE",
    "quote": "USDT",
    "amount": "1",
    "side": "SELL"
}

Tips for QA testing:

@fengtality fengtality requested a review from nikspz November 28, 2024 20:31
@fengtality fengtality changed the base branch from main to development November 28, 2024 20:31
@nikspz
Copy link
Contributor

nikspz commented Nov 29, 2024

Test performed:

  • Cloned and installed PR371 + Client latest dev branch
  • connected pancakeswap_binance-smart-chain_mainnet and pancakeswap_ethereum_arbitrum successfully
  • checked balance successfully
  • checked amm/price : ok
  • created/ started amm_arb using pancakeswap_binance-smart-chain_mainnet successfully
  • amm/trade: ok

@cardosofede cardosofede merged commit c554d8e into development Dec 2, 2024
5 checks passed
@cardosofede cardosofede deleted the fix/pancake-router branch December 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development 2.2.0
Development

Successfully merging this pull request may close these issues.

[Bug] Pancakeswap router not returning valid routes for /amm/price
3 participants