Add some tooltips for things that felt like they could use them #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ | |||
| <enum>QTabWidget::Rounded</enum> | |||
| </property> | |||
| <property name="currentIndex"> | |||
| <number>0</number> | |||
| <number>1</number> | |||
There was a problem hiding this comment.
We need a unit test for this one :D
| @@ -342,6 +367,9 @@ | |||
| <height>22</height> | |||
| </size> | |||
| </property> | |||
| <property name="toolTip"> | |||
| <string><html><head/><body><p>Audio buffer size (in frames). This generally determines the <span style=" font-weight:700;">minimum</span> audio latency the system can achieve. Actual audio latency will be greater.</p><p>Selecting a buffer size that is too small may lead to audible glitches, particularly if the system becomes more heavily loaded.</p><p><span style=" font-weight:700;">Use with caution.</span></p></body></html></string> | |||
There was a problem hiding this comment.
There is one potential problem with HTML in the translatable text. When using a standard editor to do the translation all the HTML code is displayed in plain text (not sure whether there are more elaborated ones out there). If the translator does not know HTML she might end up translating things like "body" or "style". Not quite sure if that ever happened but at least ones I encountered mismatching brackets in a translation which made Qt unable to render them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.