Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a download agent to pooch/Deveraux calls #231

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Adds a download agent to pooch/Deveraux calls #231

merged 6 commits into from
Nov 20, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Nov 20, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Fixes an issue related to pooch in recent ReadTheDocs builds.

Other information:

@RondeauG RondeauG requested a review from Zeitsperre November 20, 2024 16:53
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added notebooks Run tests against notebooks docs labels Nov 20, 2024
@RondeauG RondeauG changed the title Adds a download agent to Deveraux calls Adds a download agent to pooch/Deveraux calls Nov 20, 2024
Zeitsperre
Zeitsperre approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@github-actions github-actions bot added the approved Approved for additional tests label Nov 20, 2024
@RondeauG RondeauG merged commit f603ea7 into main Nov 20, 2024
17 checks passed
@RondeauG RondeauG deleted the fix-rtd branch November 20, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs notebooks Run tests against notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @Zeitsperre