Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devereaux to add User-Agent to requests #234

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Update devereaux to add User-Agent to requests #234

merged 5 commits into from
Nov 27, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 25, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Adds a user-agent to the pooch call in order to deal with forbidden remote requests
  • Fixes the URL joining logic in load_registry and deveraux
  • Removes an unused import in conftest.py

Does this PR introduce a breaking change?

No.

Other information:

readthedocs/readthedocs.org#11763

@Zeitsperre Zeitsperre requested a review from RondeauG November 25, 2024 19:57
@Zeitsperre Zeitsperre self-assigned this Nov 25, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Nov 25, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added notebooks Run tests against notebooks docs labels Nov 27, 2024
@Zeitsperre Zeitsperre merged commit ac92a5b into main Nov 27, 2024
17 checks passed
@Zeitsperre Zeitsperre deleted the update-devereaux branch November 27, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests docs notebooks Run tests against notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @RondeauG