-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support coloring with multiline span #6
Comments
Thank you for trying the new feature so quickly.
I understand your concern. However, it is difficult to implement it right away, because there are some technical challenges, and I currently have no clear ideas on how to solve them. Therefore, I will treat it as a long-term task. I hope you don't mind waiting for a while. |
Thank you for replying! It is sufficient that it has been filed as an open issue, so it is fine if it takes a long time to resolve as it is a long term issue. |
In Release v0.19.0 · hymkor/go-multiline-ny, multi-line syntax highlighting to allow color changes across line boundaries is supported. This feature is enabled with updating update the code to assign values to the fields as shown below
Since it is difficult to handle regions enclosed by The source file of the example is https://github.com/hymkor/go-multiline-ny/blob/fa092b68055ea896fee0bf81768a148ac760b8f2/examples/example.go |
Thank you for fast fixing! |
AFAIU,
readline.Highlight
is applied as per-line basis.go-multiline-ny/main.go
Lines 399 to 403 in bb1bd51
But, there is a syntax like multiline comments and multiline literals.(This examples uses
```...```
as multiline string literal, and/* ... */
as multiline comment)FindAllStringIndex()
method only receives a single line, so multiline pattern won't be matched.Of course, I know using multi-line patterns in readline is a rare case and difficult to implement, but ideally I'd be happy if go-multiline-ny supported it.
The text was updated successfully, but these errors were encountered: