Bug: user-defined max_decoding_message_size is not used in some cases (client streaming response decoding)

[checkline1052]

Bug Report

Version

tonic 0.9.1
tonic-build 0.9.1

Platform

Fedora 37 x86_64

Crates

tonic

Description

I recently updated tonic to v0.9.1, and I experienced breaking changes due to DEFAULT_MAX_RECV_MESSAGE_SIZE. It's ok, we can increase this limit with max_decoding_message_size() and max_encoding_message_size() (in both server and client !), and it did fix "message lenth too large" errors for normal requests/responses (I increased it to 60MB).

However, I still have these errors in stream responses decoding, when calling if let Some(stream_response) = request.message().await.unwrap() :

TonicStatus status: OutOfRange, message "Error, message length too large: found 6877902 bytes, the limit is: 4194304 bytes", details: [], metadata: MetadataMap { headers: {} }

In Grpc::create_response() if found that in a some cases, the codec::decode::Streaming is created without the user-defined max_decoding_message_size, when calling Streaming::new_empty(...) here :

tonic/tonic/src/client/grpc.rs

Lines 352 to 364 in 9990e6e

	let response = response.map(|body| {
	if expect_additional_trailers {
	Streaming::new_response(
	decoder,
	body,
	status_code,
	encoding,
	self.config.max_decoding_message_size,
	)
	} else {
	Streaming::new_empty(decoder, body)
	}
	});

But I do no have a complete understanding of the tonic crate, so I did not open a pull-request for this issue yet

Thank you !

[LucioFranco]

Hi @checkline1052, I wrote a test to try and reproduce what you were stating above but from what I can tell everything works as intended. Please take a look at #1363 and see if this differs from your code.

[checkline1052]

Thanks you for the integration test, I was doing something wrong !