Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Compiling protobuf v3 files with optional fields requires setting Prost Config.protoc_args.
To enable compiling optional fields, some versions of protoc require the
--experimental_allow_proto3_optional
flag. This experimental flag was added in Protobuf 3.12. The recent Protobuf 3.15 release implies this flag is no longer required.However, I have
protoc v3.15.5
locally and I still get this error:protoc failed: msg.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.
.Solution
This change modifies the Tonic build config to store
protoc_args
and pass them to the Prost config prior to compiling protos.