Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Docker build #1307

Merged
merged 14 commits into from
Jul 24, 2024
Merged

Conversation

dennypradipta
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

This PR will solve #1306

How did you implement / how did you fix it

  1. Add Docker build test in each OS (Linux, Windows, and MacOS)

How to test

  1. Run workflow

@dennypradipta dennypradipta self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (6a29470) to head (30cc8e9).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   62.51%   63.37%   +0.85%     
==========================================
  Files         112      109       -3     
  Lines        3391     3421      +30     
  Branches      591      584       -7     
==========================================
+ Hits         2120     2168      +48     
+ Misses       1079     1066      -13     
+ Partials      192      187       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennypradipta
Copy link
Contributor Author

Seems like we can't use windows-latest and macos-latest to build Monika.

It fails when using windows-latest:
image
Mentioned here:
docker/setup-buildx-action#292
moby/buildkit#616

It fails when using macos-latest:
image
Mentioned here:
docker/setup-qemu-action#137

.github/workflows/docker-build.yml Outdated Show resolved Hide resolved
@dennypradipta dennypradipta merged commit 0e501dd into hyperjumptech:main Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants