Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrays in FFI #2629

Closed
mversic opened this issue Aug 16, 2022 · 1 comment
Closed

Arrays in FFI #2629

mversic opened this issue Aug 16, 2022 · 1 comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Aug 16, 2022

At the moment iroha_ffi converts arrays into pointers when generating extern functions to follow the C convention of passing arrays by pointer. An alternative would be to wrap an array into a structure in which case it would be passed as a value. I don't think that we should change the current behavior but it's worth opening a discussion about it
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested Red labels Aug 16, 2022
@mversic mversic mentioned this issue Aug 16, 2022
Merged
@appetrosyan
Copy link
Contributor

I think the current approach is reasonable.

@appetrosyan appetrosyan removed the Red label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @mversic