Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed potential deadlocks by opening sessions only on demand #1439

Merged
merged 95 commits into from
Oct 15, 2021
Merged

Fixed potential deadlocks by opening sessions only on demand #1439

merged 95 commits into from
Oct 15, 2021

Conversation

dejsenlitro
Copy link
Contributor

@dejsenlitro dejsenlitro commented Oct 11, 2021 •
edited
Loading

Removed potential deadlocks in Multitenancy, Issue credential v2, Present proof v2 and mediation protocols by opening sessions on demand and closing them asap.

Additional info in this issue: #1417

ianco and others added 30 commits October 11, 2021 12:36
@ianco
Refactoring in prep for adding connectionless proof demo
5ec60e6 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Add connectionless proof request support
debb995 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Display url's
a96cefd 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Fix url for qr code
8848263 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Fix url for qr code
0d6de45 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Fix url's for proof request
1c1e046 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Use birth date instead of age in cred and proof request
7792065 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Update some docs
9df08f5 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Update some docs
cb7302c 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@andrewwhitehead
import cleanups
997ef2d 
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Run integration tests using external ledger and tails server
f1d25f4 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Run integration tests using external ledger and tails server
c390124 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Run integration tests using external ledger and tails server
1196397 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Some misc cleanup
1355c8b 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Fix aip 20 behaviour
58c3852 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@pavlos-p
Typos in the demo's README.md
154bf9c 
Signed-off-by: pavlos-p <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Fix typo
a0b3de1 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@shaangill025
log info for non supported problem-report code
0c8b6e1 
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@burdettadam
root profile in inbound transport
8a4d7a5 
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@burdettadam
removed explicit param handling
caaec4c 
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@acuderman
feat(IDENT-3334): Encode DIDComm messages before pushing It to the queue
198e986 
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@acuderman
feat(IDENT-3334): Fix Basewire injection
037c8db 
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@acuderman
fix(IDENT-3334): Fix lint issues
5fffede 
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@acuderman
fix(IDENT-3334): Fix lint issues
8b5c86b 
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@acuderman
fix(IDENT-3334): Add blank line
5fe5930 
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@acuderman
Revert "fix(IDENT-3334): Add blank line"
47b5a17 
This reverts commit a67df43.

Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@shaangill025
updates based on feedback
2b5497e 
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Make requested attributes and predicates required on indy proof request
2bd3872 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Fix order of startup params for faber agent
6673660 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
@ianco
Fix order of startup params for faber agent
009ea36 
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
arin.hlaj and others added 13 commits October 11, 2021 12:36
fix IDENT-3523: Renamed variable
a4b4d76 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Started implementation
c7d5549 
Signed-off-by: arin.hlaj <[email protected]>
feat IDENT-3524: Removed session openning for base manager
1498b38 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Fixed Multitentnat manager session opening
5bd788c 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Fixed failing tests
ea62ae0 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Removed unneded test setup
f627d36 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Fixed potential deadlock
1a0ef10 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Added addition variable for context.profile
a792132 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Fixed to use async with profile.session()
4fb0d65 
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3524: Removed potential deadlock
34acd82 
Signed-off-by: arin.hlaj <[email protected]>
Lint fix
85c11a2 
Signed-off-by: arin.hlaj <[email protected]>
@swcurran
Release 0.7.2-rc0 preparation
aba4a54 
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: arin.hlaj <[email protected]>
fix IDENT-3372: Fixed Faber demo
f27c232 
Signed-off-by: arin.hlaj <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #1439 (87cb2f8) into main (1ec676a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1439   +/-   ##
=======================================
  Coverage   94.59%   94.60%           
=======================================
  Files         483      483           
  Lines       29664    29707   +43     
=======================================
+ Hits        28061    28104   +43     
  Misses       1603     1603

@dejsenlitro dejsenlitro force-pushed the feat-IDENT-3372-askar-session-deadlock-v2 branch from 38e267a to f27c232 Compare October 11, 2021 10:47
@dejsenlitro dejsenlitro changed the title Feat ident 3372 askar session deadlock v2 Feat ident 3372 askar session deadlock v2 Oct 11, 2021
Merge branch 'main' of github.com:globalid/aries-cloudagent-python in…
23dac1f 
…to feat-IDENT-3372-askar-session-deadlock-v2

Signed-off-by: arin.hlaj <[email protected]>
@dejsenlitro dejsenlitro force-pushed the feat-IDENT-3372-askar-session-deadlock-v2 branch from 3e33260 to 23dac1f Compare October 11, 2021 12:48
@dejsenlitro dejsenlitro changed the title Feat ident 3372 askar session deadlock v2 Fixed potential deadlocks by opening sessions only on demand Oct 12, 2021
@dejsenlitro
Copy link
Contributor Author

@andrewwhitehead @swcurran if possible can you please review this?

@swcurran
Copy link
Contributor

@TimoGlastra @ianco @shaangill025 -- can you please take a look at this? Ideally, coordinate to prevent duplicate work -- add a comment here if you are able to take this on.

There are a lot of changed, but using a repeated pattern, so hopefully the effort to review won't be too bad.

@ianco
Copy link
Contributor

ianco commented Oct 15, 2021

I'll take a look today. @dejsenlitro can you catch up with the latest updates to the main branch?

@dejsenlitro
Copy link
Contributor Author

Thanks @ianco! Updated with main branch

@ianco
Copy link
Contributor

ianco commented Oct 15, 2021

Everything looks good, however when I combine with my other PR (#1431) I still get some askar deadlock errors in the integration tests. I'll investigate further before I approve this PR.

@ianco ianco requested a review from shaangill025 October 15, 2021 21:22
@ianco ianco merged commit fec69f1 into openwallet-foundation:main Oct 15, 2021
@ianco ianco mentioned this pull request Oct 20, 2021
Merged
@ctomc ctomc deleted the feat-IDENT-3372-askar-session-deadlock-v2 branch July 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianco ianco ianco approved these changes

@shaangill025 shaangill025 Awaiting requested review from shaangill025

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.