Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker images and GHA for publishing images #2076

Merged
merged 33 commits into from
Jan 23, 2023
Merged

Docker images and GHA for publishing images #2076

merged 33 commits into from
Jan 23, 2023

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Jan 11, 2023

This PR is a reopening of #1888 and still contains some of the issues discussed on that PR. If someone wants to tackle some of those issues (whether actually using this branch or just taking inspiration -- either way is fine with me!), I'd be happy to see this fixed up and working.

cc @WadeBarnes @swcurran

dbluhm added 29 commits August 6, 2022 17:31
@dbluhm
feat: add dockerfiles for building images from repo
10d99eb 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Merge branch 'main' into feature/standalone-docker
2f403b0
@dbluhm
test: add gha for testing with in repo dockerfiles
978e35b 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: add nightly workflow for indy aca-py
6c641fe 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: add publish indy-python workflow
2fe605a 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: add publish workflow
9603484 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: add actions for publishing images
4c9795f 
Signed-off-by: Daniel Bluhm <[email protected]>

fix: url construction for indy sdk download

Signed-off-by: Daniel Bluhm <[email protected]>

fix: bad labels on steps

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Merge pull request openwallet-foundation#66 from Indicio-tech/test/gh…
9084229 
…a-image-builds

Github actions
@dbluhm
Merge branch 'main' into feature/standalone-docker
57ea9d7
@dbluhm
Merge branch 'main' into feature/standalone-docker
b7137a8
@dbluhm
Merge branch 'main' into feature/standalone-docker
96bc6a8
@dbluhm
docs: description of images
1472629 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
docs: add key differences section
412fb17 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Simplify actions and images
1e85957 
* test: build and run without push

Signed-off-by: Daniel Bluhm <[email protected]>

* test: further slim tests-indy

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: store image in docker

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: load true for build of images

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: bad workflow for tests-indy

Signed-off-by: Daniel Bluhm <[email protected]>

* refactor: indy images all from one Dockerfile

And don't publish indy-python

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: no tty in gha

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: clean up workflows

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: id of jobs and conditions

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: publish indy meta and condition

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: tags for release on indy image publish

Signed-off-by: Daniel Bluhm <[email protected]>

* refactor: move local actions to .github folder

Signed-off-by: Daniel Bluhm <[email protected]>

* feat: create nightly testing workflows

Signed-off-by: Daniel Bluhm <[email protected]>

* ci: use reusable workflows to DRY things up

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: env values

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: env values again

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: don't use env

Signed-off-by: Daniel Bluhm <[email protected]>

* refactor: unified pr and nightly workflows

Signed-off-by: Daniel Bluhm <[email protected]>

* fix: run on python 3.6

Signed-off-by: Daniel Bluhm <[email protected]>

* docs: update docs

Signed-off-by: Daniel Bluhm <[email protected]>

* chore: update label on workflow

Signed-off-by: Daniel Bluhm <[email protected]>

* chore: fix typo in docs

Signed-off-by: Daniel Bluhm <[email protected]>

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Merge branch 'main' into feature/standalone-docker
ab06fe8
@dbluhm
Merge branch 'main' into feature/standalone-docker
417f435
@dbluhm
Merge branch 'main' into feature/standalone-docker
38252c0
@dbluhm
fix: remove no longer needed files
0eb63e0 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: paths in integrationtests worflow
a90e568 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: run python 3.6 on ubuntu-20.04
9baf15c 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: use repo owner instead of actor as username
024b0be 
This averts issues that occur in the hyperledger org to publish values
to ghcr.io

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: attempt to fix tagged images
a613242 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: manually tagged indy image has python-version
564a9af 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: clarifications in docker images readme
dd7310f 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Merge branch 'main' into feature/standalone-docker
25941d9
@dbluhm
Merge branch 'main' into feature/standalone-docker
9657ddd
@dbluhm
Merge branch 'main' into feature/standalone-docker
1c7afa5
@dbluhm
fix: metadata action in publish workflows
47e97bc 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Merge branch 'main' into feature/standalone-docker
b30568e
@dbluhm dbluhm added the help wanted Extra attention is needed label Jan 11, 2023
@dbluhm
Copy link
Contributor Author

dbluhm commented Jan 11, 2023

It looks like there are still some bugs to workout with the images published with the workflows that are triggered by a release. The images are still getting overwritten, as they are not getting tagged with the python version or -indy tag.

References:

@WadeBarnes
Copy link
Contributor

Thanks @dbluhm

@WadeBarnes WadeBarnes self-assigned this Jan 11, 2023
@WadeBarnes
Copy link
Contributor

Tagging myself as an assignee, but others are free to help out too.

@WadeBarnes
Copy link
Contributor

WadeBarnes commented Jan 13, 2023 •
edited
Loading

Latest commit fixes the release and workflow_dispatch triggered runs of the Publish ACA-Py Image workflows so the expected images and image tags are created. I've also limited the builds to py3.6 (for legacy) and py3.9. I'd consider this a good first pass at the image builds. An enhancement would be to include the tests for each python version and gate the image creation and publishing based on the tests passing.

Test runs of each of the workflows and triggers can be found here:

Resulting images can be found here:

The resulting images have not been tested yet.

@swcurran
Copy link
Contributor

Looks good! What do the tags on the images indicate? E.g. the tm-11 and 1.0.0-rc18?

@WadeBarnes
Copy link
Contributor

Looks good! What do the tags on the images indicate? E.g. the tm-11 and 1.0.0-rc18?

The tm-11 tag was one I used when testing the manually triggered workflow runs.
image

The 1.0.0-rc18 tag is the result of creating a release to test the release triggered workflow; https://github.com/WadeBarnes/aries-cloudagent-python/releases/tag/1.0.0-rc18

@WadeBarnes
Copy link
Contributor

WadeBarnes commented Jan 21, 2023 •
edited
Loading

The latest commits add support for mutil-platform images. Images include support for amd64, arm64, and i386. The ACA-Py with Indy SDK images do not support arm64 for the reasons noted in .github/workflows/publish-indy.yml

The resulting, test-multi-arch tagged images can be found here; https://github.com/WadeBarnes/aries-cloudagent-python/pkgs/container/aries-cloudagent-python

@WadeBarnes WadeBarnes marked this pull request as ready for review January 21, 2023 14:06
@WadeBarnes
Copy link
Contributor

I'd say this PR is ready for review. Once merged we should add a ticket to track the enhancement to add the gating tests as described here; #2076 (comment)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit a0621a0 into openwallet-foundation:main Jan 23, 2023
@WadeBarnes
Copy link
Contributor

Great, I'll add the ticket to track adding the tests.

@WadeBarnes WadeBarnes mentioned this pull request Jan 23, 2023
Closed
@WadeBarnes
Copy link
Contributor

Issue to track the addition of the unit tests; #2085

@WadeBarnes WadeBarnes mentioned this pull request Jan 24, 2023
Closed
@dbluhm dbluhm deleted the feature/standalone-docker branch July 7, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

@ianco ianco ianco approved these changes

@andrewwhitehead andrewwhitehead Awaiting requested review from andrewwhitehead

Assignees

@WadeBarnes WadeBarnes

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbluhm @WadeBarnes @swcurran @ianco @esune