Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of band stage 1 #576

Merged
merged 30 commits into from
Jun 26, 2020
Merged

Conversation

nrempel
Copy link
Contributor

@nrempel nrempel commented Jun 24, 2020

Nicholas Rempel and others added 24 commits May 20, 2020 15:07
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
@swcurran
Copy link
Contributor

w00t!!!

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #576 into master will decrease coverage by 0.34%.
The diff coverage is 81.75%.

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   96.79%   96.45%   -0.35%     
==========================================
  Files         240      247       +7     
  Lines       12805    13088     +283     
==========================================
+ Hits        12395    12624     +229     
- Misses        410      464      +54     

Nicholas Rempel added 2 commits June 24, 2020 15:54
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request introduces 2 alerts when merging 201126b into afa4575 - view on LGTM.com

new alerts:

  • 1 for __eq__ not overridden when adding attributes
  • 1 for Unused local variable

Signed-off-by: Nicholas Rempel <[email protected]>
@andrewwhitehead andrewwhitehead merged commit 7bdae13 into openwallet-foundation:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants