Set liveliness status on fatal ledger error #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
- Coverage 98.81% 98.70% -0.12%
==========================================
Files 250 250
Lines 13351 13385 +34
==========================================
+ Hits 13193 13211 +18
- Misses 158 174 +16 |
sklump
previously approved these changes
Jul 31, 2020
Signed-off-by: Ian Costanzo <[email protected]>
|
Found some issues, so pulling the PR for further testing |
Signed-off-by: Ian Costanzo <[email protected]>
|
Fixed, added support for resetting liveliness on admin api's |
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
WadeBarnes
requested changes
Aug 2, 2020
Signed-off-by: Ian Costanzo <[email protected]>
WadeBarnes
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo [email protected]
issue #638
Set live check to False when we get a fatal ledger error