Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes agent create node, when check deployment is alive if pod is not created will cause crash #47

Closed
hightall opened this issue Oct 24, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@hightall
Copy link
Contributor

Expected Behavior

Can update node status after node is deployed.

Current Behavior

After node is deployed, cause crashed when check node status.

Traceback (most recent call last):
  File "main.py", line 9, in <module>
    create_node()
  File "/app/operations/create_node.py", line 162, in create_node
    _create_fabric_node()
  File "/app/operations/create_node.py", line 140, in _create_fabric_node
    print(pod, pod.status)
AttributeError: 'NoneType' object has no attribute 'status'

Possible Solution

Check if pod is not null object at first.

Steps to Reproduce

  1. make start
  2. MOCK=False PROXY=http://9.59.196.20:8085/engine make start-dashboard-dev run at your computer
  3. create new agent
  4. apply agent
  5. create new node

Context (Environment)

OS: Ubuntu 18.04
Arch: x86_64
Kubernetes version: 1.13
Docker version: 19.03.3
Docker compose version: 1.24.1

Detailed Description

Possible Implementation

@hightall hightall self-assigned this Oct 24, 2019
@hightall hightall added the bug label Oct 24, 2019
@hightall hightall added this to the v1.0.0 milestone Oct 24, 2019
jiahaoc1993 added a commit that referenced this issue Oct 24, 2019
[Fix #47] Fix node status check crash for k8s agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant