Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add menuconfig support for server deployment config #170

Merged
merged 1 commit into from
Jul 30, 2020
Merged

feat: add menuconfig support for server deployment config #170

merged 1 commit into from
Jul 30, 2020

Conversation

hightall
Copy link
Contributor

close #169

Signed-off-by: Haitao Yue [email protected]

@hightall hightall requested a review from a team July 29, 2020 15:44
@hightall hightall self-assigned this Jul 29, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2020

This pull request introduces 3 alerts when merging 2bf9deb into 5a5468c - view on LGTM.com

new alerts:

  • 3 for Modification of parameter with default

yeasy
yeasy approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@yeasy yeasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to update the documentation to include this important change.

@hightall
Copy link
Contributor Author

Would be better to update the documentation to include this important change.

ok

@hightall hightall merged commit aa8a09c into hyperledger:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeasy yeasy yeasy approved these changes

Assignees

@hightall hightall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add menuconfig support for server deployment variable configuration
2 participants
@hightall @yeasy