Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BatchMutation.Flush()'s retry logic tunable for the Go client #796

Closed
F21 opened this issue Apr 3, 2017 · 2 comments
Closed

Make BatchMutation.Flush()'s retry logic tunable for the Go client #796

F21 opened this issue Apr 3, 2017 · 2 comments
Assignees
@pawanrawal
Milestone
v0.8

Comments

@F21
Copy link
Contributor

F21 commented Apr 3, 2017 •
edited by manishrjain
Loading

Calling Flush() on a BatchMutation retries forever (every 5ms). It would be nice if this is tunable.

For example, if the batch fails after retrying 5 times, abort and return an error.
@F21 F21 changed the title Make BatchMutation.Flush()'s retry logic tunable Make BatchMutation.Flush()'s retry logic tunable for the Go client Apr 3, 2017
@janardhan1993 janardhan1993 self-assigned this Apr 3, 2017
@manishrjain manishrjain added this to the v0.8 milestone Apr 4, 2017
@manishrjain manishrjain assigned manishrjain and unassigned pawanrawal May 5, 2017
@manishrjain
Copy link
Contributor

@janardhan1993 : Can you have a look?

@pawanrawal pawanrawal mentioned this issue Jul 13, 2017
Closed
@pawanrawal
Copy link
Contributor

This is now supported through the MaxRetries option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawanrawal pawanrawal

Labels
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

Client/retries hypermodeinc/dgraph
4 participants
@janardhan1993 @manishrjain @F21 @pawanrawal