[Feature Request] render password as text symbol

[namaek2]

• image is from : https://github.com/stepanzubkov/where-is-my-sddm-theme/commits?author=stepanzubkov

I want to render password dots as asterisk like this image.

I looked up code little bit and find out dots are rendered by CRenderer::renderRect function. Is there any plan to render password as text?

[vaxerski]

MRs welcome

[HarshNarayanJha]

Hey, I would like to work on this. I am quite new to C++, and digging down, here's what I found

The exact line which is drawing the dots

hyprlock/src/renderer/widgets/PasswordInputField.cpp

Line 271 in eb63207

g_pRenderer->renderRect(box, fontCol, dots.rounding);

So I might try to use a CLabel to draw the * (or whatever is set in config). Right?

[PaideiaDilemma]

Hey @HarshNarayanJha

FYI, I implemented this. Just wanted to wait for #508 until i create the MR.
You are welcome to look at my current implementation here: PaideiaDilemma@057b6b8

Let me know what you think the config option should be named like.

[HarshNarayanJha]

Didn't see that one! 😓

Your implementation looks great! So you basically check if textFormat and textAsset exists and then draw it, otherwise dots are drawn.
What I think (if I am not wrong), say textAsset did get allocate, in this case dots must be drawn as fallback option

// say this failed
dots.textAsset = g_pRenderer->asyncResourceGatherer->getAssetByID(dots.textResourceID);

src/renderer/widgets/PasswordInputField.cpp

if (!dots.textFormat.empty()) {
    if (!dots.textAsset)
+		g_pRenderer->renderRect(box, fontCol, dots.rounding);
        break;
    g_pRenderer->renderTexture(box, dots.textAsset->texture, fontCol.a, dots.rounding);
} else {
    g_pRenderer->renderRect(box, fontCol, dots.rounding);
}

As (per my understanding) this case would result in nothing being typed in the input field.

For the name of the config option, dots_text_format is good, but dots_mask_character sound better to me. You choose!

[PaideiaDilemma]

Didn't see that one! 😓

Yeah sorry, I could have posted that i am going to implement that.

What I think (if I am not wrong), say textAsset did get allocate, in this case dots must be drawn as fallback option

Yeah so this is intended. We set forceReload to true as long as the asset is not ready yet. So we relay on the asyncResourceGatherer to successfully render that asset at some point. Otherwise we will busy render forever.
That works the same as the background widget for example.
I am not 100% happy with the break in the loop though