Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django-allauth v64 migration #655

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

django-allauth v64 migration #655

wants to merge 8 commits into from

Conversation

dpgraham4401
Copy link

@dpgraham4401 dpgraham4401 commented Sep 20, 2024 •
edited
Loading

Description

This PR migrates dj-rest-auth to the newest major version of django-allauth. It, unfortunately, forces `dj-rest-auth to increment the major version since it follows django-allauth support for django, and drops support for django > 4.2.

Related tickets

closes #646

see also #639

Notes

  • fixes a format error that was causing CI to fail from refresh token is not shown in the swagger #247
  • I removed a couple test that were dependent on objects that are no longer exported from django-allauth (see a89f6df)
  • Since these changes add support for django 5.0, it replaces django.utils.timezone usage (which was deprecated in django 4.1 and removed in django 5) with the standard library datetime module (see django deprecateion notice here)
  • I converted the requirement.pip files to requirements.txt file which is newer widely used name. I did this for convenience for my local development environment, but can be reverted. The changes also include changes to the docs.
  • adjust the CI to reflect the removed and added support for django version.

@dpgraham4401
fix formatting errors from iMerica#247
77c0b96
@dpgraham4401
bump django-allauth dependency constrains to >=64.0.0
348dc2c
@dpgraham4401
remove failing test that rely on attributes that are no longer export…
a89f6df 
…ed from the django-allauth package >= 64.0.0
@dpgraham4401
convert requirements.pip files to requirements.txt files
eb0fb01
@dpgraham4401
Replace usage of django.utils.timezone module (which was deprecated i…
990c543 
…n django 4.1 and removed in django>=5.0) with the python datetime module

    see django documentation here https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-5-0
@dpgraham4401
increment dj-rest-auth major version since these changes introduce br…
2a4b9f1 
…eaking changes and remove support for django<4.2
@dpgraham4401
remove django 3.2 support (which has reached end of life, and is no l…
a008dd4 
…onger supported by django or django-allauth) and some minor additional fixes to use of datetime module
@dpgraham4401 dpgraham4401 marked this pull request as draft September 20, 2024 01:52
@Downchuck
Copy link

@iMerica Checking in on the status of this PR?

@dan-blanchard
Copy link

  • Since these changes add support for django 5.0, it replaces django.utils.timezone usage (which was deprecated in django 4.1 and removed in django 5) with the standard library datetime module (see django deprecateion notice here)

django.utils.timezone was not removed entirely and django.utils.timezone.now is still the recommended way to get tz-aware datetimes in the Django docs. What was removed were a few aliases they had before and supports for pytz. The changes you have related to that are unnecessary, and datetime.utcnow() is actually deprecated and not something that you should be replacing it with (because ironically utcnow() does not get you are tz-aware date).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

django-allauth >= v64.0.0 support
3 participants
@dpgraham4401 @Downchuck @dan-blanchard