Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use allauth uid encoding if installed #266

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Use allauth uid encoding if installed #266

merged 2 commits into from
Jun 2, 2021

Conversation

squio
Copy link

@squio squio commented Jun 1, 2021

This PR overrides #258 and fixes #76

Highlights:

  • use token generator and uid decoder from Allauth if it is in installed apps
  • fix test by using Allauth token generator and uid encoder if allauth app is installed
  • add note in README how to setup test environment, I missed that ;-)

All tests pass, coverage is unchanged

@squio squio mentioned this pull request Jun 1, 2021
Closed
@iMerica iMerica merged commit 1f28787 into iMerica:master Jun 2, 2021
@iMerica iMerica mentioned this pull request Jun 2, 2021
Closed
@marcosantar93 marcosantar93 mentioned this pull request Jun 14, 2021
Open
iMerica added a commit that referenced this pull request Jun 17, 2021
@iMerica
Revert "Use allauth uid encoding if installed (#266)"
c2e721c 
This reverts commit 1f28787.
@iMerica iMerica mentioned this pull request Jun 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UID for password reset incorrectly uses base64
2 participants
@squio @iMerica