Allow enqueueSnackbar children to be a function and pass the snack key #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Love the PR @jgodi. Can you also provide a sandbox with customised snackbars to go in the docs website for this feature? |
|
Yes, where is the docs site? |
|
It's not open sourced. You can provide a sandbox link here and I'll add it to the docs website. @jgodi |
|
Ok, sounds good. I will work on that now. |
|
@iamhosseindhv Done. Here is the link: https://codesandbox.io/embed/y7kq6441jj BTW. Love the library. Keep up the great work! |
|
Nice one @jgodi ❤️ |
|
Feature has been published |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of custom, fancy snack messages that we need to be disabled in our application. These messages also have dismiss actions inside of them. The children property needs to pass the key to it, so that we can properly close the message.
This PR checks to see if the children property is a function and then will invoke that function passing the key property in. Existing functionality is still in tact, this just further enhances the customization.
Thank you,
Joshua