Fix types for onExited, OnEntered, and onClose handlers #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @JoseLion. I'll review, merge and publish changes over the weekend ❤️ |
|
@iamhosseindhv thank you for taking the time to review this PR 🙂 any news so far? |
|
I would love to get my hands on this fix as well. Will be a huge help for integrating with redux. |
|
Thanks for your patience and contribution. fix has been released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the types for onExited, OnEntered, and onClose handlers to match the handlers of the library instead of the ones in
SnackbarPropsof material-ui. Specifically, it adds the lastkeyargument to the handlers.@iamhosseindhv Nice work on this library I really liked it. And thanks for adding TypeScript types too. Keep up the great work🙂