Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom variants does not work anymore #251

Closed
kikoanis opened this issue Apr 18, 2020 · 5 comments
Closed

Custom variants does not work anymore #251

kikoanis opened this issue Apr 18, 2020 · 5 comments

Comments

@kikoanis
Copy link

kikoanis commented Apr 18, 2020

It seems that something has changed in the last release that prevent custom variants (custom classes) from implementing. I looked at the changes and I could not put my finger on what has changed. This is related to release 0.9.10

implementing something like this, does not work any more

<SnackbarProvider
    classes={{
        variantSuccess: classes.success,
        variantError: classes.error,
        variantWarning: classes.warning,
        variantInfo: classes.info,
    }}
>
@iamhosseindhv
Copy link
Owner

Could you provide a reproduction?
Here's a working example with v0.9.10.
https://codesandbox.io/s/friendly-wilson-dwniy?file=/App.js

@kikoanis
Copy link
Author

kikoanis commented Apr 19, 2020

oh does it? It used to. The example you provided does not work as expected anymore. Clicked on success (the one that is supposed to be overridden) but still shows the original background color.

went back to 0.9.9 and it showed success with aqua background color.

What am I missing?

@picosam
Copy link

picosam commented Apr 19, 2020

I confirm. It seems to be broken in v0.9.10.

@iamhosseindhv
Copy link
Owner

You're right. Bug is fixed and published in v0.9.11. Appreciate if you could confirm the fix.

@kikoanis
Copy link
Author

I can confirm the fix is working fine. Thanks for the quick response and the fix.
Great library BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants