-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material-UI 5.0 support #412
Comments
I've seen some posts indicating that this It didn't work for me and I've got the same issue, but hopefully YMMV. |
No, it seems that the current build still imports The styling here really needs to be redone to match Emotion styled. |
I'm using MUI v5.0.0-beta.1 and notistack v1.0.6-next.1, and also getting the withStyles issues. Are there plans to release a new version that supports v5 beta? |
Please have look through PR #387 and read this comment to see why it was closed. TLDR: We need to implement the solution suggested on the comment above. I have to implement this on my free time so PRs are welcome to save time and make notistack compatible as soon as possible. |
any eta on material-ui v5 support? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I just posted a PR for upgrading to v5. #418 |
Would really like to see at least 1 tag that supports MUI 5 beta. |
This comment has been minimized.
This comment has been minimized.
Thanks to @joemaffei, you can now download a MUI v5 beta compatible version using |
Expected Behavior
Project should be able to compile
Current Behavior
notistack imports makeStyle and friends from @material-ui/core/styles, which doesn't seem to export these functions anymore, and thus we need to update the imports to import from @material-ui/styles instead.
Steps to Reproduce
Upgrade an existing project to material-ui 5, or create a test project.
Context
I'm trying to upgrade to material-ui 5.0 (it's in beta at the moment), to see if that solves some of my issues with an autocomplete form, but then it breaks functionality with notistack.
Your Environment
The text was updated successfully, but these errors were encountered: